Emit telemetry for user interactions in the local results view#1976
Merged
robertbrignull merged 4 commits intomainfrom Jan 18, 2023
Merged
Emit telemetry for user interactions in the local results view#1976robertbrignull merged 4 commits intomainfrom
robertbrignull merged 4 commits intomainfrom
Conversation
aeisenberg
approved these changes
Jan 17, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Nice!
The local results view should probably get an overhaul, but it's great that you were able to add telemetry without any major changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds telemetry for all UI interactions in the local results view.
We use the same telemetry message type that was used for the variant analysis results view, but we have to use a slightly different technique for sending the message when state changes. The local results view is not a modern react component and it uses
setStaterather thanuseState, which means we can't useuseEffecthere and instead have to add a call to the telemetry every time we callsetState.I've managed to trigger each of these telemetry events apart from
local-results-show-raw-results. I can't quite work out the series of conditions that need to happen to be able to trigger this code. But I think if it ever does trigger then telemetry is reasonable.Checklist
ready-for-doc-reviewlabel there.